Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slot use in examples for all components in the root folder #1294

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Aug 10, 2022

this PR updates all components in the root primer/ folder to use the new .with_#{slot_name} syntax in docs examples

Updated components

  • ButtonComponent
  • DetailsComponent
  • Dropdown
  • ImageCrop
  • LayoutComponent
  • LinkComponent
  • MenuComponent
  • TabComponent
  • PopoverComponent
  • SubheadComponent

Screenshots

button:
image

details:
image

dropdown:
image

image crop:
image

layout:
image

link:
image

menu:
image

popover:
image

subhead:
image

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2022

🦋 Changeset detected

Latest commit: 4a47d18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxriverlynn mxriverlynn temporarily deployed to github-pages August 10, 2022 18:14 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 10, 2022 19:36 Inactive
@mxriverlynn mxriverlynn marked this pull request as ready for review August 10, 2022 19:47
@mxriverlynn mxriverlynn requested review from a team and jonrohan August 10, 2022 19:47
@mxriverlynn mxriverlynn enabled auto-merge (squash) August 10, 2022 19:47
@mxriverlynn mxriverlynn merged commit 52fed9a into main Aug 10, 2022
@mxriverlynn mxriverlynn deleted the mxriverlynn/update-root-component-slot-use branch August 10, 2022 20:45
@primer-css primer-css mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants